[wp-trac] [WordPress Trac] #60835: Fix and improve handling of uploading of font files

[WordPress Trac]

#60835: Fix and improve handling of uploading of font files
----------------------------------------------------+---------------------
 Reporter:  azaozz                                  |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  high                                    |   Milestone:  6.7
Component:  Upload                                  |     Version:  6.5
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-testing has-patch has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by youknowriad):

 Hey folks, there's obviously a lot going on here, a lot of back and forth,
 so I might be missing some context but I do recall that for the 6.5
 release, we discussed that having a way to change the upload folder when
 calling the low level upload function was definitely needed but we didn't
 want to introduce that late in the cycle.

 Looking at the PR shared by @azaozz it does address that concern and it's
 clear to me that the current code is too convoluted to understand even for
 someone that participated in it. I think the PR is a large improvement in
 terms of maintainability and I would support it. It's very unclear to me
 what the drawbacks of the change are reading the comments before, I'd
 appreciate a TLDR there if possible.

 I wish it was committed earlier in the 6.6 cycle though as it seems that
 it was ready so I'd propose that we commit it early in the 6.7 cycle to
 assess for any impact.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60835#comment:79>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform