[wp-trac] [WordPress Trac] #61574: [PHP] Remove PHP < 7.2 code

WordPress Trac noreply at wordpress.org
Sat Jul 6 14:52:21 UTC 2024


#61574: [PHP] Remove PHP < 7.2 code
---------------------------------------------+-----------------------------
 Reporter:  ayeshrajans                      |       Owner:  SergeyBiryukov
     Type:  enhancement                      |      Status:  reviewing
 Priority:  normal                           |   Milestone:  6.7
Component:  General                          |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch commit has-unit-tests  |     Focuses:
---------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"58682" 58682]:
 {{{
 #!CommitTicketReference repository="" revision="58682"
 Code Modernization: Remove obsolete comments about older PHP versions.

 This commit:
 * Removes various comments referencing PHP versions which are no longer
 supported.
 * Removes various comments containing “hints” of things to do after a
 particular PHP version drop. These hints are incorrect/not actionable for
 various reasons, so have no value:
  * Even though a function could be turned into a closure, removing the
 function would be a backward compatibility break which is not acceptable,
 so this suggestion is not actionable.
  * Short ternaries are forbidden by the coding standard exactly to prevent
 the faulty code suggested in the comment from getting into the codebase.

 Follow-up to [1243/tests], [6543], [11816], [29861], [29864], [34928],
 [35369], [36698], [38694], [50786], [58678].

 Props jrf, ayeshrajans.
 See #61574.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61574#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list