[wp-trac] [WordPress Trac] #61574: [PHP] Remove PHP < 7.2 code

[WordPress Trac]

#61574: [PHP] Remove PHP < 7.2 code
---------------------------------------------+-----------------------------
 Reporter:  ayeshrajans                      |       Owner:  SergeyBiryukov
     Type:  enhancement                      |      Status:  reviewing
 Priority:  normal                           |   Milestone:  6.7
Component:  General                          |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch commit has-unit-tests  |     Focuses:
---------------------------------------------+-----------------------------

Comment (by jrf):

 Replying to [comment:3 ayeshrajans]:
 > Yay, thank you!
 > I went through the compat files, `PHP_VERSION` constants, and
 `function_exists` calls to look for snippets to remove. But I think you
 are absolutely right, there has to be more things that we could remove.
 >
 > Happily offering an extra pair of hands if you have any suggestions
 where to look for snippets to remove :)

 I've rebased what I prepared earlier this week after the commit made by
 @SergeyBiryukov (thanks!) and opened [https://github.com/WordPress
 /wordpress-develop/pull/6975 PR 6975]. Definitely not claiming
 completeness, but this should get us another step closer.

 @ayeshrajans Would you like to review that PR ?

 I came across these when searching for similar things, including
 `ini_get()`, `@requires` (in the tests), `->markTestSkipped()` (tests),
 `PHP_VERSION_ID`, `phpversion()`, `function_exists()`, `class_exists()`,
 `extension_loaded()` and some more things (searches made in relation to
 some changes which will be proposed for the PHPUnit workflow).

 I've fixed things of which I felt sufficiently confident, but only skimmed
 through the results of those searches, so there may well be more which can
 be removed based on those searches alone.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61574#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform