[wp-trac] [WordPress Trac] #61573: Tests: Reduce usage of assertEquals for 6.7
WordPress Trac
noreply at wordpress.org
Thu Jul 4 13:02:39 UTC 2024
#61573: Tests: Reduce usage of assertEquals for 6.7
------------------------------+--------------------
Reporter: SergeyBiryukov | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.7
Component: Build/Test Tools | Version:
Severity: normal | Keywords:
Focuses: |
------------------------------+--------------------
Follow-up to:
* #60706 (6.6)
* #59655 (6.5)
* #58956 (6.4)
* #57855 (6.3)
* #56800 (6.2)
* #55654 (6.1)
* #54726 (6.0)
* #53364 (5.9)
* #52482 (5.8)
* #38266 (5.7)
The `assertEquals()` test method does not check that the types of the
expected and actual values match. This can hide subtle bugs especially
when the values are falsey.
Tasks:
* Switch to using `assertSame()` when the type of the value in the
assertion is important
* Replace overall usage of `assertEquals()` with type-strict assertion
methods, with the aim of potentially removing its usage altogether
To help ease the effort of merging tests, changes should also be made
upstream in the Gutenberg repository.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/61573>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list