[wp-trac] [WordPress Trac] #59595: Improve performance of WP_Theme_JSON::compute_style_properties
WordPress Trac
noreply at wordpress.org
Wed Jan 17 19:10:11 UTC 2024
#59595: Improve performance of WP_Theme_JSON::compute_style_properties
-----------------------------------------+--------------------------
Reporter: spacedmonkey | Owner: pereirinha
Type: enhancement | Status: assigned
Priority: normal | Milestone: 6.5
Component: Editor | Version: 5.8
Severity: normal | Resolution:
Keywords: has-patch changes-requested | Focuses: performance
-----------------------------------------+--------------------------
Changes (by joemcgill):
* keywords: has-patch => has-patch changes-requested
Comment:
@pereirinha it's looking like the current approach won't work, based on
@oandregal's [https://github.com/WordPress/wordpress-
develop/pull/5567#pullrequestreview-1821200846 feedback in the PR].
I think we could either look at setting these caches in
`wp_add_global_styles_for_blocks()`, or as a new property in
`WP_Theme_JSON_Resolver` that produces the `WP_Theme_JSON` object used in
that function via `WP_Theme_JSON::get_styles_for_block()`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59595#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list