[wp-trac] [WordPress Trac] #59655: Tests: Reduce usage of assertEquals for 6.5
WordPress Trac
noreply at wordpress.org
Tue Feb 20 18:14:57 UTC 2024
#59655: Tests: Reduce usage of assertEquals for 6.5
--------------------------------------+---------------------
Reporter: hellofromTonya | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.5
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Comment (by SergeyBiryukov):
In [changeset:"57673" 57673]:
{{{
#!CommitTicketReference repository="" revision="57673"
Tests: Use `assertSame()` in `wp_read_image_metadata()` tests.
This ensures that not only the return values match the expected results,
but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should
generally be preferred to `assertEquals()` where appropriate, to make the
tests more reliable.
Follow-up to [49/tests], [198/tests], [34374], [48937], [52269].
Props costdev.
See #59655.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59655#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list