[wp-trac] [WordPress Trac] #58683: Cast return value to int in functions that use ceil()
WordPress Trac
noreply at wordpress.org
Sat Feb 17 16:32:52 UTC 2024
#58683: Cast return value to int in functions that use ceil()
------------------------------+-----------------------
Reporter: crstauf | Owner: audrasjb
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 6.5
Component: General | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch commit | Focuses:
------------------------------+-----------------------
Comment (by SergeyBiryukov):
In [changeset:"57650" 57650]:
{{{
#!CommitTicketReference repository="" revision="57650"
Tests: Use `assertSame()` in `get_comment_pages_count()` tests.
This ensures that not only the return values match the expected results,
but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should
generally be preferred to `assertEquals()` where appropriate, to make the
tests more reliable.
Follow-up to [27055], [48937], [54402], [57244], [57648].
Props costdev.
See #58683, #59655.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58683#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list