[wp-trac] [WordPress Trac] #31352: Media icons are not retina friendly

[WordPress Trac]

#31352: Media icons are not retina friendly
------------------------------+---------------------------------
 Reporter:  iseulde           |       Owner:  joedolson
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  6.5
Component:  Media             |     Version:  3.9
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  ui, administration
------------------------------+---------------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Thanks for the commit! I noticed that `wp_mime_type_icon()` tests now fail
 when run separately:
 {{{
 phpunit --filter test_wp_mime_type_icon

 ...

 There were 2 failures:
 1) Tests_Post_Attachments::test_wp_mime_type_icon
 Failed asserting that 'http://example.org/wp-
 includes/images/media/default.svg' contains "images/media/default.png".

 S:\home\wordpress.test\develop\tests\phpunit\tests\post\attachments.php:511

 2) Tests_Post_Attachments::test_wp_mime_type_icon_video
 Failed asserting that 'http://example.org/wp-
 includes/images/media/video.svg' contains "images/media/video.png".

 S:\home\wordpress.test\develop\tests\phpunit\tests\post\attachments.php:520
 }}}

 For some reasons, they pass when running the whole test suite, so this
 needs further investigation.

 Additionally, the text icon is no longer displayed for PDF files after
 [57638] ([attachment:"31352.pdf-icon.png"] is the before/after
 screenshot), so something else is missing here, perhaps there's a MIME
 type mismatch somewhere in the function.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/31352#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform