[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings

[WordPress Trac]

#54370: Add an option to configure the site icon in general settings
---------------------------------------+-----------------------
 Reporter:  jameskoster                |       Owner:  jorbin
     Type:  task (blessed)             |      Status:  reopened
 Priority:  normal                     |   Milestone:  6.5
Component:  General                    |     Version:  5.9
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------

Comment (by jorbin):

 Replying to [comment:85 afercia]:
 > > I think removing this was premature and it would be best to add it
 back and use it for aria-describedby since that will be consistent with
 the rest of the experience on this page.
 >
 > I'm not sure you are fully getting how `aria-describedby` is meant to be
 used. Usually, we use it to associate an input field to a description. In
 this case, there's no input field. There's buttons that get dynamically
 hidden. Associating the 'choose' button to the descriptions is technically
 possible but not recommended, as the button gets hidden when an image is
 set. I don't think we should use `aria-describedby` in this UI and thus
 the IDs are unnecessary. They weren't used anyways in the original commit.

 Going based off https://www.w3.org/TR/WCAG20-TECHS/ARIA1.html, this seems
 as though the exact case that the third example provides "Using aria-
 describedby property to provide more detailed information about the
 button"


 Replying to [comment:87 andraganescu]:
 > I would like to chime in my support fot the idea to not represent the
 visuals using a browser at all. Mainly because browsers have a revamped
 appeal as a product and we're in a new proliferation of options and
 whatever we place here will most likely not match UIs of up and coming
 products.
 >

 For desktop users, favicons are still the norm and an important part of a
 site's identity. While arc does go in alternative directions with the UI,
 it still uses favicons as a part of the site identity. This exemplifies
 why it's important for there to be both icons, though with PWA never
 having really gotten going in iOS, I don't know how much saving to home
 screens actually takes place.


 I believe the next steps are:

 1. Finish up the work ongoing in https://github.com/WordPress/wordpress-
 develop/pull/6109
 2. Wire in the new UI both on the settings screen and in the Customizer.
 3. Update the alt text both on the settings screen and in the Customizer.
 4. Update the link in the site icon block so that it points to the correct
 place. (Also should fix the casing of Site Icon there so that it is
 consistent throughout WordPress)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:88>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform