[wp-trac] [WordPress Trac] #59442: Duplicate query in WP_Query
WordPress Trac
noreply at wordpress.org
Thu Feb 15 16:33:01 UTC 2024
#59442: Duplicate query in WP_Query
-------------------------------------------------+-------------------------
Reporter: spacedmonkey | Owner: (none)
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.6
Component: Query | Version: 6.2
Severity: normal | Resolution:
Keywords: has-patch dev-feedback early | Focuses:
changes-requested | performance
-------------------------------------------------+-------------------------
Changes (by joemcgill):
* keywords: has-patch dev-feedback commit early changes-requested => has-
patch dev-feedback early changes-requested
* owner: joemcgill => (none)
* milestone: 6.5 => 6.6
Comment:
Replying to [https://core.trac.wordpress.org/ticket/59442#comment:24
spacedmonkey]:
> I would like to see this committed in WP 6.5.
Sorry, I didn't see your response here prior to the beta release. Even so,
I'm moving this to the 6.6 milestone and leaving unassigned for anyone
else to pick up, but am happy to review again once updated.
The current PR from @thekt12 has not yet been updated to address the
feedback from @peterwilsoncc and I.
Specifically, I think the following changes are needed:
- Simplifying the approach to match either
[https://core.trac.wordpress.org/attachment/ticket/59442/59442.diff
59442.diff] or the [https://github.com/WordPress/wordpress-
develop/pull/5295/commits/e69cc40698b103ad9ce330d94b6491cc9b9e362c early
commit] referenced by @spacedmonkey above.
- Adding a unit test that demonstrates the issue being fixed by this
change (e.g., it should fail when run in isolation prior to the changes
being applied)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59442#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list