[wp-trac] [WordPress Trac] #57854: Twenty Twenty-One: Pull Quote block font-size issue
WordPress Trac
noreply at wordpress.org
Tue Feb 13 21:22:51 UTC 2024
#57854: Twenty Twenty-One: Pull Quote block font-size issue
-----------------------------------------------+---------------------------
Reporter: nidhidhandhukiya | Owner:
| hellofromTonya
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 6.5
Component: Bundled Theme | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch commit has-testing-info | Focuses: css
-----------------------------------------------+---------------------------
Changes (by hellofromTonya):
* status: reviewing => closed
* resolution: => fixed
Comment:
In [changeset:"57631" 57631]:
{{{
#!CommitTicketReference repository="" revision="57631"
Bundled Themes: Support pullquote block typography options in Twenty
Twenty-One.
Pullquotes were not inheriting the correct styling from the block
editor. This commit resolves the issue by supporting typography options.
1. The `font-family` variable remains on the paragraph (both editor and
front) so the citation continues to use the body font even when the site
redefines `var(--pullquote--font-family)`.
2. The `font-size`, `font-style`, `font-weight`, `letter-spacing` and
`line-height` are set on the Pullquote block to allow overriding with the
sidebar settings. Then the block's paragraph element inherits those
styles.
3. When the settings do not give a custom `line-height` from the sidebar,
these stylesheets set the paragraph to `var(--pullquote--line-height)`
instead of inheriting 1.6 from the block styles. This patch uses
`:where()` to avoid increasing specificity.
Moving styles from the paragraph element to the block should not affect
the citation, which has had its own styles for `font-size`, `font-style`,
`font-weight` and `letter-spacing`.
Follow-up to [56959], [56451], [55089], [55088], [49574], [49320],
[49216].
Props sabernhardt, poena, darshitrajyaguru97, harshgajipara, shailu25,
skyakash12.
Fixes #57854.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57854#comment:62>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list