[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings

[WordPress Trac]

#54370: Add an option to configure the site icon in general settings
----------------------------------------------+-----------------------
 Reporter:  jameskoster                       |       Owner:  jorbin
     Type:  enhancement                       |      Status:  reopened
 Priority:  normal                            |   Milestone:  6.5
Component:  General                           |     Version:  5.9
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |     Focuses:
----------------------------------------------+-----------------------

Comment (by kebbet):

 Replying to [comment:67 jorbin]:
 > Reopening to encourage continued discussion and potential interaction of
 the UI.
 >
 >
 > @jameskoster
 > > The preview is prone to becoming outdated as browsers evolve, and
 doesn't capture the full scope of the site icon usage.
 >
 > It hasn't yet in the 9 years that it's been in use in the customizer, so
 I don't think this is a concern.
 >
 > > In terms of the UI, I'm wondering if we could design something that
 resembles the 'Media' panel of the Site Logo block more closely?
 >
 > A couple of issues with that UI (and it might be good to get those fixed
 up there)
 > 1. The icon is circle-cropped in the UI even if the icon is not actually
 circle-cropped.
 > 2. It's more clicks to complete tasks.
 > 3. The Site Logo block has the toggle "Use as site icon", the rest of
 core refers to the feature  in Title Case.
 >
 > @kebbet Thanks, do you want to do a new PR with those changes?

 I might get time tomorrow (in 12h or so), but otherwise a new ticket can
 be created with follow ups for later, so this can be closed off.

 Margins are tricky when stacking. Might need to flex on parent element.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:68>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform