[wp-trac] [WordPress Trac] #40331: The placeholder attribute should not be used as a replacement for a label

[WordPress Trac]

#40331: The placeholder attribute should not be used as a replacement for a label
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  joedolson
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.5
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots a11y-task has-patch  |     Focuses:  ui,
  needs-refresh                                  |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots a11y-task has-patch => has-screenshots a11y-
     task has-patch needs-refresh


Comment:

 I tried to test the patches but they don't apply cleanly for me.
 Going through the code changes, they all make sense to me and I'm all for
 these changes.

 I noticed only a few things to check in the `40331-wp-link-url.diff patch:

 - Missing ID on the input field.
 - Not sure about the CSS rule for the selector `div.mce-flow-layout-item >
 div` which seems to break the TinyMCE breadcrumb at the bottom of the
 editor.
 - Anyways, I think we should use `align-items: flex-end` instead of
 `align-items: end`?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40331#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform