[wp-trac] [WordPress Trac] #60227: HTML API: Add external test suite
WordPress Trac
noreply at wordpress.org
Mon Feb 5 15:53:30 UTC 2024
#60227: HTML API: Add external test suite
--------------------------------------+---------------------
Reporter: jonsurrell | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 6.5
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Comment (by dmsnell):
One of the challenges here is that these tests cover the entire HTML5
specification. Now this is important because we don't want WordPress to
miss something in the specification and then go down a trail of broken
parsing: this is why we created the HTML API, so we can put behind us the
days of ad-hoc HTML parsing.
The skipped tests in this case are very much a `@todo` comment that will
shrink as continue developing the HTML API, whereas full support is the
trajectory with or without these tests.
One option we have is to manually sift through the thousands of tests and
break them up into pieces, committing one at a time as we add support, but
I hope everyone recognizes the undue hassle that would imply. This is an
external library being vendored in, we should have the full set or none at
all so that it remains simple to update from the source.
That being said, it sounds like the main complaint is people thinking that
skipped tests implies they should be doing more work on something they are
unfamiliar with? On this point would it be something you feel better about
if the skipped tests made a void assertion and returned from the test so
that it looks like it passes when in fact it's being skipped?
For those of us working on the HTML API that's marginally less valuable
because it removes the ease of gauging progress from test completion, but
we can always comment out the lines or change them to see the more
accurate picture; we already have to do this with all the `@covers`
annotations which obscure the true coverage picture.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60227#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list