[wp-trac] [WordPress Trac] #51870: Update all focusable elements to use the new focus style

[WordPress Trac]

#51870: Update all focusable elements to use the new focus style
-------------------------------------------------+-------------------------
 Reporter:  johnbillion                          |       Owner:  joedolson
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.5
Component:  Administration                       |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  design-feedback needs-refresh                  |  accessibility, css
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch needs-design-feedback => has-
     screenshots has-patch needs-design-feedback needs-refresh


Comment:

 I reviewed [attachment:"51870.diff"] Impressive research work by @kebbet
 in finding all these focus style occurrences. I'm all for this change as
 it improves accessibility and consistency throughout the user interface.

 There's a few things to address:
 - Many elements miss the transparent outline for Windows High Contrast
 Mode. Although it's a pre-existing issue, I think this ticket is a good
 opportunity for a fix. Basically wherever there is a box-shadow focus
 style with no transparent outline, a transparent outline should be added.
 - There's a few things to check in the patch, for example when the new 2
 pixels box-shadow sums up to the border, thus looking like a 3 pixels
 outline. Instead of posting a very long comment with a list of the things
 to improve, I thought it is more convenient to attach a patch with
 comments, for the sole purpose of a code review.
 [attachment:"51870-commented.diff"] should not be committed.

 Glad to submit a new patch soon if no one beats me to it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51870#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform