[wp-trac] [WordPress Trac] #62750: PHPcs Fixes in `class-ftp.php` (was: PHPcs Fixes on WordPress core.)

[WordPress Trac]

#62750: PHPcs Fixes in `class-ftp.php`
--------------------------+-------------------------------
 Reporter:  viralsampat   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  coding-standards
--------------------------+-------------------------------
Changes (by audrasjb):

 * keywords:  dev-feedback needs-testing => needs-patch
 * version:  trunk =>


Old description:

> Hello Team,
>
> I have checked wp-admin & wp-includes folders and found few PHPcs fixes.
>
> - No space before closing parenthesis is prohibited
> - Line indented incorrectly; expected at least 1 tabs, found 0
>
> I have applied a patch which will fix this issue.
>
> Thanks,

New description:

 Hello Team,

 I have checked wp-admin & wp-includes folders and found few PHPcs fixes.

 - No space before closing parenthesis is prohibited
 - Line indented incorrectly; expected at least 1 tabs, found 0

 I have applied a patch which will fix this issue.

 Thanks,

 ''[EDIT: the related changes are related to `wp-admin/includes/class-
 ftp.php`, see comment #2]''

--

Comment:

 Hello and thank you for opening this ticket, however ID3 is an external
 library so the related files should be modified on the related upstream
 repository. Also, we don't usually make much WPCS changes on
 deprecated.php since these functions are, well, deprecated :)

 I'm renaming this ticket and description to only mention class-ftp.php.

 (and please note that the ticket should reflect which changes are proposed
 and where, otherwise we would end up with a ton of ticket labelled as
 "PHPCS fixes in Core" 🙂).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62750#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform