[wp-trac] [WordPress Trac] #62713: Policies accordion does not work for plugin names with non-English characters

[WordPress Trac]

#62713: Policies accordion does not work for plugin names with non-English
characters
-------------------------+-------------------------------------------------
 Reporter:  ecgan        |       Owner:  (none)
     Type:  defect       |      Status:  new
  (bug)                  |
 Priority:  normal       |   Milestone:  6.8
Component:  Privacy      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, javascript, administration,
                         |  privacy
-------------------------+-------------------------------------------------

Comment (by ecgan):

 Hi @sabernhardt, thanks for adding the links to previous tickets for more
 contexts. It shows that we can't rely on just plugin names (because there
 can be two identical plugins with same plugin names but in different
 plugin directories: `activate-akismet/akismet.php` and `activate-akismet-
 old/akismet.php`).

 I think using an increment is a viable approach.

 However, before we do that, I am also curious: why do we use plugin names
 in the first place? If we make the change from using plugin name to using
 an increment, will we break things?

 I found that the use of plugin names / `$sanitized_policy_name` comes from
 the following links:

 - https://core.trac.wordpress.org/ticket/49264
 - https://core.trac.wordpress.org/changeset/50161
 - https://github.com/WordPress/wordpress-develop/pull/957

 I don't see any reason mentioned for why we want to use plugin names. So,
 I think it may be okay to make the change to using an increment.

 Should we include people from the above links into our discussion here?

 Also, from the links above, the issue has been around since WordPress
 version 5.7.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62713#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform