[wp-trac] [WordPress Trac] #62283: Fix: Loose Comparisons in ms-functions.php

WordPress Trac noreply at wordpress.org
Thu Dec 26 23:52:42 UTC 2024


#62283: Fix: Loose Comparisons in ms-functions.php
--------------------------------+------------------------------------------
 Reporter:  debarghyabanerjee   |       Owner:  SergeyBiryukov
     Type:  enhancement         |      Status:  reviewing
 Priority:  normal              |   Milestone:  6.8
Component:  Networks and Sites  |     Version:
 Severity:  minor               |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by SergeyBiryukov):

 Hi there, thanks for the PR!

 Just noting that some of the proposed changes, e.g. `1 ===
 $primary->archived` would not work as expected, because these properties
 are numeric strings, not integers. I will make some adjustments on commit
 based on a closer review and testing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62283#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list