[wp-trac] [WordPress Trac] #62635: Twenty Nineteen : Latest Comment Block text color differs on frontend and editor on adding background color

[WordPress Trac]

#62635: Twenty Nineteen : Latest Comment Block text color differs on frontend and
editor on adding background color
-------------------------------------------------+-------------------------
 Reporter:  pitamdey                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info changes-requested                 |
-------------------------------------------------+-------------------------
Changes (by poena):

 * keywords:  has-patch needs-testing has-testing-info => has-patch needs-
     testing has-testing-info changes-requested


Comment:

 I would like to encourage everyone to take the time to research and
 understand what is causing the problems,  and to consider what impact the
 suggested changes may have. It is sometimes better to ask a few questions
 more.

 Twenty Nineteen has a feature that changes the text color depending on the
 background color.
 If the white color was removed from this CSS; then the text would no
 longer be accessible.
 The color contrast ratio between the background and text would be too low
 to pass the accessibility requirements.
 This change would also affect all paragraphs inside HTML elements with
 this class, not only the Latest Comments block.
 {{{
 .has-dark-gray-background-color p {
   color: #fff;
 }
 }}}

 The text color would also change on live websites, and it would be an
 unexpected change for the users.

 Twenty Nineteen uses SASS. The CSS files are generated from the SCSS
 files.
 If you change the CSS files directly, the changes will be overwritten when
 the SCSS files are built.
 You can find the commands to build the files in the package.json file.

 I recommend only submitting the changes to the SCSS files, because
 otherwise there may be merge conflicts that make it more difficult to test
 the patches.
 Then, the tester can download the patch and re-build the CSS files
 locally.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62635#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform