[wp-trac] [WordPress Trac] #39893: Twenty Seventeen Header Media: YouTube Embed Does Not Fill Screen
WordPress Trac
noreply at wordpress.org
Tue Dec 3 17:46:36 UTC 2024
#39893: Twenty Seventeen Header Media: YouTube Embed Does Not Fill Screen
--------------------------------------+------------------------------
Reporter: cingrosso | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version: 4.7.2
Severity: normal | Resolution:
Keywords: dev-feedback needs-patch | Focuses: javascript
--------------------------------------+------------------------------
Changes (by domainsupport):
* keywords: dev-feedback => dev-feedback needs-patch
Comment:
Because this issue is built into the way
[https://make.wordpress.org/core/2016/11/26/video-headers-in-4-7/
WordPress adds support for custom video headers] I believe that this
affects all themes that make use of custom video headers and to fix the
issue, the JS that @bradyvercher created in his plugin should to be merged
into `/wp-includes/js/wp-custom-header.js` (along with something similar
to [#comment:10 my suggestion] to fix the issue when the aspect ratio is
less than the container ratio).
As such the summary should probably be changed to "Custom Header: YouTube
Embed Does Not Fill Screen" too seeing as this bug likely affects all
themes that use custom video headers.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39893#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list