[wp-trac] [WordPress Trac] #62610: Twenty Seventeen - Image block having unnecessary border if duotone and link is applied.

[WordPress Trac]

#62610: Twenty Seventeen - Image block having unnecessary border if duotone and
link is applied.
-------------------------------------------------+-------------------------
 Reporter:  nidhidhandhukiya                     |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:  6.7.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info has-screenshots     |     Focuses:
  has-patch changes-requested                    |
-------------------------------------------------+-------------------------
Changes (by poena):

 * keywords:  has-testing-info has-screenshots has-patch => has-testing-info
     has-screenshots has-patch changes-requested


Comment:

 Hi

 I don't think that this patch is the correct solution.

 The theme uses a box shadow to style links.
 The theme then overrides that default link style on linked images in
 several places.

 It would not be logical for the theme to first add the CSS and then
 override it again through this patch.


 {{{
 style.css
 /* Fixes linked images */
 .entry-content a img,
 .comment-content a img,
 .widget a img {
         -webkit-box-shadow: 0 0 0 8px #fff;
         box-shadow: 0 0 0 8px #fff;
 }
 }}}


 {{{
 colors-dark.css
 /* Fixes linked images */
 .colors-dark .entry-content a img,
 .colors-dark .comment-content a img,
 .colors-dark .widget a img {
         -webkit-box-shadow: 0 0 0 8px #222;
         box-shadow: 0 0 0 8px #222;
 }
 }}}


 {{{
 editor-style.css
 /* Fixes linked images */
 a img {
         background: #fff;
         -webkit-box-shadow: 0 0 0 6px #fff;
         box-shadow: 0 0 0 6px #fff;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62610#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform