[wp-trac] [WordPress Trac] #61954: Twenty Twenty-One: Remove the use of empty rulesets (was: Twenty Twenty-one Theme: Remove the use of empty rulesets)

WordPress Trac noreply at wordpress.org
Thu Aug 29 14:14:10 UTC 2024


#61954: Twenty Twenty-One: Remove the use of empty rulesets
-------------------------------------------------+-------------------------
 Reporter:  viralsampat                          |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing dev-feedback has-      |     Focuses:
  patch has-testing-info 2nd-opinion             |
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  needs-testing dev-feedback has-patch has-testing-info =>
     needs-testing dev-feedback has-patch has-testing-info 2nd-opinion


Comment:

 [https://github.com/WordPress/twentytwentyone/pull/64 PR 64] purposely
 kept those lines and added a comment because the
 [https://wordpress.org/plugins/theme-check/ Theme Check plugin] had
 required the `.sticky` class.

 I ran the plugin before and after applying the patch. Both times, it only
 recommended—not required—the `.sticky` class.
 > RECOMMENDED .sticky css class is recommended in your theme css.

 Compiling the patch SCSS does not affect the CSS files, but it does change
 the `.map` files.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61954#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list