[wp-trac] [WordPress Trac] #60548: Image editor: improve the browsePopup function

[WordPress Trac]

#60548: Image editor: improve the browsePopup function
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  6.7
Component:  Media                    |     Version:  6.3
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch has-testing-info commit      |  javascript
-------------------------------------+-------------------------------------
Changes (by joedolson):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58946" 58946]:
 {{{
 #!CommitTicketReference repository="" revision="58946"
 Media: Fix viewport scrolling and code style in image rotation.

 Change `browsePopup` to use `onkeydown`, pass the `event` parameter from
 the calling control, and adjust variable naming style.

 The `browsePopup` method used for the image rotation menu used `onkeyup`
 to trigger events, which prevented capturing browser scroll actions with
 arrows occurring on `onkeydown`.

 Props afercia, deepakvijayan, nirajgirixd, joedolson, antpb.
 Fixes #60548.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60548#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform