[wp-trac] [WordPress Trac] #58798: Fix possible PHP warning in /wp-includes/feed.php
WordPress Trac
noreply at wordpress.org
Tue Aug 27 02:17:08 UTC 2024
#58798: Fix possible PHP warning in /wp-includes/feed.php
--------------------------+------------------------------
Reporter: zahardoc | Owner: johnjamesjacoby
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.7
Component: Feeds | Version: 6.2.2
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+------------------------------
Changes (by johnjamesjacoby):
* owner: (none) => johnjamesjacoby
* status: new => assigned
* milestone: Awaiting Review => 6.7
Comment:
Hi @zahardoc, thanks for making this ticket here.
I've personally confirmed your findings, and would like to get this fixed
in the next major release.
@nihar007, your patch appears to include some unintended changes, so my
plan is to base an updated patch on the Pull Request from @narenin on
GitHub (though you'll still both get props for contributing to the fix).
----
For added context, I was seeing this on a site that was running the
Seriously Simple Podcasting plugin, because is uses the `enclosure`
[https://github.com/search?q=repo%3ACastosHQ%2FSeriously-Simple-
Podcasting+%27enclosure%27&type=code post-meta key] with only a single-
line entry, rather than the multi-line format that WordPress is coded to
expect (see: `do_enclose()`).
----
Additionally, I think the same fix should be applied to both the
`rss_enclosure()` and `atom_enclosure()` functions.
----
Lastly, these functions are ooooold, so I'll be resisting the urge to do
''any'' other improvements to the surrounding code, hugging closely to the
suggested changes already here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58798#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list