[wp-trac] [WordPress Trac] #21521: Audit use of set_time_limit()

[WordPress Trac]

#21521: Audit use of set_time_limit()
-----------------------------------------------------+---------------------
 Reporter:  ryan                                     |       Owner:  (none)
     Type:  enhancement                              |      Status:  new
 Priority:  normal                                   |   Milestone:  6.7
Component:  Bootstrap/Load                           |     Version:  3.4.1
 Severity:  normal                                   |  Resolution:
 Keywords:  needs-patch dev-feedback good-first-bug  |     Focuses:  docs
-----------------------------------------------------+---------------------
Changes (by jorbin):

 * keywords:  needs-patch dev-feedback => needs-patch dev-feedback good-
     first-bug
 * focuses:   => docs
 * milestone:   => 6.7


Comment:

 Let's get this finished up for 6.7! I think the writing the remaining
 inline docs needed would be a good first bug for someone.

 Here are all of the current uses of `set_time_limit`:

 - wp-admin/includes/file.php - `wp_edit_theme_plugin_file`
 This has an inline doc and is necessary for the loopback to ensure plugin
 file updates don't cause white screens

 - wp-admin/includes/update-core.php - `update_core`
 This could use an inline doc.

 - wp-admin/includes/class-wp-automatic-updater.php -
 `WP_Automatic_Updater::update`
 This includes an inline doc about the loopback request.

 - wp-admin/includes/class-wp-upgrader.php -
 `‎WP_Upgrader::install_package`
 This could use an inline doc.

 - wp-admin/includes/ajax-actions.php - `wp_ajax_get_revision_diffs`
 This is not documented. It was introduced to fix #24757.

 - wp-includes/ID3/module.audio.mp3.php
 This is a 3rd party library. I'm ok with it as is.

 - wp-includes/PHPMailer/SMTP.php
 This is a 3rd party library. I'm ok with it as is.


 - wp-includes/comment.php - `pingback`
 This could use an inline comment explaining that this function is used to
 call external servers. It's been in WP basically forever.

 - wp-includes/class-pop3.php
 I think an inline comment could be added but it's also fine if one isn't
 since this is sort of a 3rd party code.

 - wp-includes/deprecated.php
 As this code is deprecated, I don't think it's necessary for there to be
 an inline doc.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/21521#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform