[wp-trac] [WordPress Trac] #61578: Issue with search functionality in installed themes section

[WordPress Trac]

#61578: Issue with search functionality in installed themes section
-------------------------------------+-------------------------------------
 Reporter:  nithi22                  |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  6.6.2
Component:  Themes                   |     Version:  6.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-testing-   |     Focuses:  accessibility,
  info                               |  administration
-------------------------------------+-------------------------------------

Comment (by hellofromTonya):

 == Test Report for Add Themes

 Patch tested: https://github.com/WordPress/wordpress-develop/pull/6976

 === Steps to Reproduce or Test
 1. Navigate to Appearance > Themes.
 2. In the search box, enter a valid theme's name or part of a name, e.g.
 "Three".
    * Expected: Page should refresh with a list of themes with "Three" in
 their name.
 3. In the search box, press return or enter key. 🐞 Bug occurs.
    * Expected: Nothing should happen.
 4. In the search box, enter an invalid theme name, e.g. "sometheme".
    * Expected: Page should refresh with no themes listed and a "No themes
 found. Try a different search." message in the search results.
 5. In the search box, press return or enter key. 🐞 Bug occurs.
    * Expected: Nothing should happen.

 === Expected Results

 [attachment:"ThemesSearch-6.5.5.gif"] shows what used to happen before
 6.6.0.

 When testing if the patch resolves the issue:

 * Step 2. In the search box, enter a valid theme's name or part of a name,
 e.g. "Three".
    * ✅ Expected: Page should refresh with a list of installed themes with
 "Three" in their name.
 * Step 3. In the search box, press return or enter key.
    * ✅ Expected: Nothing should happen.
 * Step 4: In the search box, enter an invalid theme name, e.g.
 "sometheme".
    * ✅ Expected: Page should refresh with no themes listed and a "No
 themes found. Try a different search." message in the search results.
 * Step 5. In the search box, press return or enter key.
    * ✅ Expected: Nothing should happen.

 When reproducing a bug:

 * Step 3. In the search box, press return or enter key. 🐞 Bug occurs.
    * ❌ page refreshes to `/wp-admin/themes.php`, search box is cleared,
 and a list of installed themes is shown.

 * Step 5. In the search box, press return or enter key. 🐞 Bug occurs.
    * ❌ page refreshes to `/wp-admin/themes.php`, search box is cleared,
 and a list of installed themes is shown.

 === Environment

 - OS: macOS
 - Web Server: Nginx (using Local for 6.5.5 and 6.6.1 testing) and Docker
 (for trunk with patch testing)
 - PHP: 8.3.8
 - WordPress: 6.5.5, 6.6.1, and trunk
 - Browser: Firefox 129.0.1
 - Theme: Twenty Twenty-Four
 - Active Plugins: None

 ==== Actual Results

 ===== When reproducing a bug/defect:

 Can reproduce the issues of pressing enter/return key as shown in
 [attachment:"ThemesSearch-6.6.1.gif"]:

 * Step 3. In the search box, press return or enter key. 🐞 Bug occurs.
    * ❌ page refreshed to `/wp-admin/themes.php`, search box cleared, and
 the installed themes are shown.

 * Step 5. In the search box, press return or enter key. 🐞 Bug occurs.
    * ❌ page refreshed to `/wp-admin/themes.php`, search box cleared, and
 the installed themes are shown.

 ===== When testing the bugfix patch:

 [attachment:"ThemesSearch-withPatch.gif"] shows the results of Steps 4 and
 5.

 * Step 2. Entered "Twenty" into the search box.
    * ✅ Page refreshed to `/wp-admin/themes.php?search=Twenty` and all
 themes with "Twenty" in their name were shown.
 * Step 3. Clicked the search box field. Pressed return/enter key.
    * ✅ Nothing happened.
 * Step 4: Entered "SomeTheme" into the search box.
    * ✅ Page refreshed to `/wp-admin/themes.php?search=SomeTheme`, no
 themes were listed, and a "No themes found. Try a different search."
 message was shown.
 * Step 5. Clicked the search box field. Pressed return/enter key.
    * ✅ Nothing happened.

 == Summary

 I can reproduce the issues and with the patch, the issues are resolved.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61578#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform