[wp-trac] [WordPress Trac] #58265: Show defined but empty values for constants in Site Health

WordPress Trac noreply at wordpress.org
Thu Aug 15 14:16:21 UTC 2024


#58265: Show defined but empty values for constants in Site Health
--------------------------------------------+-----------------------------
 Reporter:  Presskopp                       |       Owner:  (none)
     Type:  enhancement                     |      Status:  new
 Priority:  normal                          |   Milestone:  Future Release
Component:  Site Health                     |     Version:  5.2
 Severity:  normal                          |  Resolution:
 Keywords:  has-screenshots good-first-bug  |     Focuses:
--------------------------------------------+-----------------------------
Changes (by Clorith):

 * keywords:  has-screenshots good-first-bug has-patch => has-screenshots
     good-first-bug
 * version:   => 5.2
 * milestone:  Awaiting Review => Future Release


Comment:

 Good point, and would indeed help avoid users thinking something is wrong.

 I wonder if perhaps, to not cause confusion, the "Defined, but empty"
 message should have emphasis, so it's easier to distinguish from a string
 that may hold "Empty" as it's value (unlikely scenario, but we don't know
 what strange strings may be used in constants out there by plugins or
 themes or custom setups).

 I don't think the debug value should be modified though, it should be the
 actual contents of the constant, and empty if it is indeed empty, as the
 debug data that's copied and shared should represent the raw value, and
 does not need to be in a user-readable format.

 Marking this for future release, as it does not currently have a valid
 patch, but happy to move forward if and when that happens.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58265#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list