[wp-trac] [WordPress Trac] #45924: Twenty Nineteen: Consider making the "—" divider in the header translatable.

WordPress Trac noreply at wordpress.org
Wed Aug 14 18:33:54 UTC 2024


#45924: Twenty Nineteen: Consider making the "—" divider in the header
translatable.
-------------------------------------------------+-------------------------
 Reporter:  kjellr                               |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  low                                  |   Milestone:  Future
                                                 |  Release
Component:  Bundled Theme                        |     Version:  5.0.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing close 2nd-   |     Focuses:
  opinion                                        |
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  has-patch needs-testing => has-patch needs-testing close 2nd-
     opinion


Comment:

 A translatable glyph probably would have been a better choice in 2018, but
 I do not recommend making the change now.

 1. The `:before` pseudo-element is in the stylesheet, and it could remain
 in the styles for sites that copied parts of the main stylesheet into a
 child theme stylesheet. Those sites would have two dividers.
 2. Anyone who might prefer a different glyph probably has adjusted the
 CSS—or else switched themes—in the past five years.

 Also, the patch does not account for the extra `0.2em` margins on the left
 and right of the divider, which still would be possible if the
 translatable string adds an HTML element (or placeholders for the open and
 close tags).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45924#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list