[wp-trac] [WordPress Trac] #61545: HTML API: Performance Improvements for 6.7

[WordPress Trac]

#61545: HTML API: Performance Improvements for 6.7
--------------------------------------+--------------------------
 Reporter:  dmsnell                   |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  6.7
Component:  HTML API                  |     Version:  6.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+--------------------------

Comment (by dmsnell):

 In [changeset:"58893" 58893]:
 {{{
 #!CommitTicketReference repository="" revision="58893"
 HTML API: Only stop on full matches for requested tag name.

 An optimization pass on the HTML API left a bug in the `matches()`
 method, whereby it would falsely detect a tag name match if the
 found tag were a lexical subset of the requested tag. This occurred
 because of the use of `substr_compare()` without checking that the
 outer lengths matched.

 This patch resolves the bug by adding the length check.

 Developed in https://github.com/wordpress/wordpress-develop/pull/7189
 Discussed in https://core.trac.wordpress.org/ticket/61545

 Follow-up to [58613].
 Props dmsnell, westonruter.
 See #61545.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61545#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform