[wp-trac] [WordPress Trac] #60364: Incorrect argument type given on number_format

[WordPress Trac]

#60364: Incorrect argument type given on number_format
--------------------------+-----------------------------
 Reporter:  krishneup     |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  6.7
Component:  Site Health   |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58847" 58847]:
 {{{
 #!CommitTicketReference repository="" revision="58847"
 Site Health: Display raw value for `max_file_uploads` on Site Health Info
 screen.

 This resolves a fatal error if `strict_types` PHP setting is enabled:
 {{{
 Argument #1 ($num) must be of type float, string given
 }}}

 Since the goal of the Site Health Info screen is to display raw values
 where possible, the `number_format()` call here does not seem to provide
 any benefit.

 Props krishneup, sabernhardt, audrasjb, SergeyBiryukov.
 Fixes #60364.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60364#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform