[wp-trac] [WordPress Trac] #58608: Twenty Twenty-One: Text color is not reflected when having background color

WordPress Trac noreply at wordpress.org
Sat Aug 3 13:00:21 UTC 2024


#58608: Twenty Twenty-One: Text color is not reflected when having background color
-------------------------------------------------+-------------------------
 Reporter:  wildworks                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots has-       |     Focuses:  ui, css
  testing-info                                   |
-------------------------------------------------+-------------------------

Comment (by wildworks):

 @shailu25 Thank you for submitting a patch.

 As I understand it, the style of this theme is managed by Sass, and the
 CSS files are generated automatically, so we cannot make changes directly
 to the CSS files. We will need to make changes using the following steps:

 - Go to the theme directory: `cd src/wp-content/themes/twentytwentyone/`
 - Install the npm library: `npm install`
 - Run watch mode: `npm run start`
 - Make changes to the file
 - Test your changes
 - When testing is complete, build the style: `npm run build`


 Once the build is complete, you will see that many files have been
 updated, not just the sass files you changed, but also `ie.css` and
 `style.css.map`, for example, but these are expected changes.

 You will need to update this section to resolve the front-end issue:

 https://github.com/t-hamano/wordpress-
 develop/blob/a799101e46ef0a042814c189a6331c23a52a100c/src/wp-
 content/themes/twentytwentyone/assets/sass/05-blocks/table/_style.scss#L32

 Additionally, when testing a patch, we will need to make sure it works
 properly in dark mode as well. Go to "Appearance > Customize > Colors &
 Dark Mode" and check "Dark Mode support". A button called "Dark Mode:
 On/Off" should appear in the bottom right of the screen.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58608#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list