[wp-trac] [WordPress Trac] #58664: Eliminate manual construction of script tags in WP_Scripts and of inline scripts on frontend/login screen

[WordPress Trac]

#58664: Eliminate manual construction of script tags in WP_Scripts and of inline
scripts on frontend/login screen
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:
                                                 |  westonruter
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  Script Loader                        |     Version:  6.3
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:  javascript
  note                                           |
-------------------------------------------------+-------------------------

Comment (by westonruter):

 In [changeset:"56750" 56750]:
 {{{
 #!CommitTicketReference repository="" revision="56750"
 Script Loader: Remove erroneous `type` attribute from `script` tag wrapper
 on login screen.

 This was causing a `_doing_it_wrong()` notice from
 `wp_remove_surrounding_empty_script_tags()`. In fact, the `type` attribute
 was added in [56748] to test this incorrect usage notice. This commit
 reverts that change.

 Follow-up to [56748].
 Unprops westonruter.
 See #58664.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58664#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform