[wp-trac] [WordPress Trac] #57711: PclZipUtilTranslateWinPath() fails when php_uname() function not available

[WordPress Trac]

#57711: PclZipUtilTranslateWinPath() fails when php_uname() function not available
--------------------------------+-----------------------------
 Reporter:  daymobrew           |       Owner:  (none)
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Future Release
Component:  External Libraries  |     Version:  6.1.1
 Severity:  minor               |  Resolution:
 Keywords:                      |     Focuses:
--------------------------------+-----------------------------
Changes (by desrosj):

 * milestone:  Awaiting Review => Future Release


Comment:

 Hi @daymobrew,

 Welcome to Trac! First, my apologies that this took so long to get a
 response.

 I did a bit of digging, and [https://github.com/phpconcept/PclZip found
 this repository on GitHub] that appears to be where this library is
 maintained. Core is running version 2.8.2, but 2.8.3 is available
 upstream. Though [https://github.com/phpconcept/PclZip#whats-new none of
 the changes appear to be related to your specific issue], and there has
 been no effort to make the library PHP >= 8 compatible. So I think it's
 fine to consider this library "adopted" by WordPress.

 I think adding a `functions_exists()` check is reasonable. However, I'm
 not too familiar with Windows, so I'm not sure what the consequences could
 be for scenarios where the logic within that `if()` statement should
 execute.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57711#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform