[wp-trac] [WordPress Trac] #59450: Initialize $url variable later in get_bloginfo()

WordPress Trac noreply at wordpress.org
Tue Sep 26 13:52:31 UTC 2023


#59450: Initialize $url variable later in get_bloginfo()
--------------------------+--------------------------
 Reporter:  Cybr          |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.5
Component:  General       |     Version:  2.3
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |     Focuses:  performance
--------------------------+--------------------------

Comment (by swissspidy):

 > The 1e4 iterations are not part of the benchmark but the warmup.

 You used 1e3 for warmup and ie5 for the benchmark. In my testing I reduced
 the 1e5 to 1e4. That's what my comment was referring to.

 But yes, I agree, overall the numbers are inconsistent, which is why I
 don't see the need in changing those `str_contains` calls to `preg_match`.

 Anyhow, as we have already established here, it makes sense to initialize
 the variable later.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59450#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list