[wp-trac] [WordPress Trac] #58831: Coding Standards fixes for WP 6.4
WordPress Trac
noreply at wordpress.org
Tue Sep 26 00:23:40 UTC 2023
#58831: Coding Standards fixes for WP 6.4
--------------------------------------+-------------------------------
Reporter: audrasjb | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses: coding-standards
--------------------------------------+-------------------------------
Comment (by SergeyBiryukov):
In [changeset:"56694" 56694]:
{{{
#!CommitTicketReference repository="" revision="56694"
Code Modernization: Rename parameters that use reserved keywords in
`phpunit/tests/media.php`.
While using reserved PHP keywords as parameter name labels is allowed, in
the context of function calls using named parameters in PHP 8.0+, this
will easily lead to confusion. To avoid that, it is recommended not to use
reserved keywords as function parameter names.
This commit renames the `$match` parameter to `$matches` in shortcode
image tests.
Note: This is enforced by WPCS 3.0.0.
Follow-up to [56693].
See #58831.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58831#comment:64>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list