[wp-trac] [WordPress Trac] #58775: Remove usage of outputting styles tags
WordPress Trac
noreply at wordpress.org
Mon Sep 25 21:24:09 UTC 2023
#58775: Remove usage of outputting styles tags
--------------------------------+---------------------------
Reporter: spacedmonkey | Owner: spacedmonkey
Type: enhancement | Status: reopened
Priority: normal | Milestone: 6.4
Component: Script Loader | Version:
Severity: normal | Resolution:
Keywords: 2nd-opinion revert | Focuses: performance
--------------------------------+---------------------------
Comment (by flixos90):
Replying to [comment:27 azaozz]:
> > The PR ensures those core styles make use of the WP_Styles API and
thus can be properly depended upon, which isn't possible as of today.
>
> Sorry but I don't understand what you are saying? This is simply **not
true**! Using the WP_Styles API does not improve handling of these styles
in the slightest. Please add examples!
No need to use exclamation points. Per the discussion in
https://wordpress.slack.com/archives/C02RQBWTW/p1695675353234609, there
are primarily two benefits of this change:
* It allows plugins (e.g. optimization plugins) to filter the CSS output.
* It allows external CSS to depend on the relevant core CSS, e.g. custom
WP Embed styles can now depend on `wp-embed-template`.
> At this time it seems that this change is a "pointless refactoring".
There are no fixes or improvements as a result of it. Please see the
WordPress philosophy in regards to doing pointless refactoring. On top of
that it could bring new bugs or regressions.
>
> In these terms I think it should be reverted until a proof that it is
actually beneficial for something.
This is not correct, the improvements were outlined several times here and
in the linked Slack conversation. If there is a foundation for actual bugs
this is introducing, then it should be revisited, so please present
examples if you have any.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58775#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list