[wp-trac] [WordPress Trac] #58458: Move the load of `array_keys` to a different level in the `WP_Hook` class

WordPress Trac noreply at wordpress.org
Thu Sep 14 13:51:39 UTC 2023


#58458: Move the load of `array_keys` to a different level in the `WP_Hook` class
-------------------------------------------------+-------------------------
 Reporter:  bor0                                 |       Owner:
                                                 |  spacedmonkey
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  General                              |     Version:  6.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests dev-feedback commit                      |  performance
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 @flixos90 I was doing a final review before commiting and noticed
 something. See blackfire profile compared
 https://blackfire.io/profiles/compare/01426068-1e58-45c7-b2bc-
 4df66ffd19f9/graph.

 I am seeing i/o and cpu improves ( less than 1% ), but I am seeing an
 increase of memory usage, around 2%. Around 155kb more memory is used. I
 am guessing this because of instead of recomputing the array_keys they are
 now stored. Is this an issue?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58458#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list