[wp-trac] [WordPress Trac] #58782: Twenty Twenty: Easily add prefers-color-scheme: dark support
WordPress Trac
noreply at wordpress.org
Mon Sep 4 19:48:20 UTC 2023
#58782: Twenty Twenty: Easily add prefers-color-scheme: dark support
-------------------------------+------------------------------
Reporter: adamzea | Owner: (none)
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: close 2nd-opinion | Focuses:
-------------------------------+------------------------------
Changes (by sabernhardt):
* keywords: => close 2nd-opinion
Comment:
Hi and welcome to WordPress Core Trac!
I like dark mode (I even created my own for Trac), but I think making
Twenty Twenty support both light and dark palettes should be left to
plugins and/or child themes.
Except for a recent bug within the editor (#59086), Twenty Twenty has had
good support for setting a light text color against a dark background in
the Customizer. Then every visitor would get the same color palette, and
anyone creating content could check it with those colors.
Twenty Twenty-One [https://make.wordpress.org/core/2020/10/22/twenty-
twenty-one-dark-mode-discussion/#comment-40118 added a checkbox] for site
owners to enable its dark mode. That theme required a commitment to making
content fit the colors of both the light and dark schemes, and visitors
can still override the sitewide choice if something does not work well in
dark mode.
As far as proposed colors within the palette, full white (`#fff`) text can
be easier for many people to read against near-black (such as `#222`) than
against full black (`#000`). Also, using `!important` could cause
problems.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58782#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list