[wp-trac] [WordPress Trac] #59738: `wp_prime_option_caches()` makes DB queries for known non-existent options (notoptions).

[WordPress Trac]

#59738: `wp_prime_option_caches()` makes DB queries for known non-existent options
(notoptions).
--------------------------------------+--------------------------
 Reporter:  peterwilsoncc             |       Owner:  flixos90
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  6.4
Component:  Options, Meta APIs        |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+--------------------------

Comment (by flixos90):

 Replying to [comment:9 hellofromTonya]:
 > The bugs were introduced during this cycle. Given RC3 is in a few days
 and final in a little over a week, risks need to be mitigated at this late
 stage in the release. Thus, I'd be okay with it going into 6.4.0 if:
 > * there's ''high confidence'' in the fix (i.e. code reviews, automated
 tests, and manual test reports).
 > * code changes are minimal.

 I think both of these are the case here, so I would support this being
 committed to the 6.4 branch, which we could probably do today. They are
 indeed not ''critical'' bug fixes, but I don't have any concerns about
 introducing other problems with this code. So I think it's worth fixing it
 now instead of shipping with the bug and fixing after.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59738#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform