[wp-trac] [WordPress Trac] #59732: Theme live preview is broken

[WordPress Trac]

#59732: Theme live preview is broken
-------------------------------------------------+-------------------------
 Reporter:  karl94                               |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  Themes                               |     Version:  5.8
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-testing-info dev-      |     Focuses:
  reviewed commit                                |
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"57010" 57010]:
 {{{
 #!CommitTicketReference repository="" revision="57010"
 Themes: Fix block theme supports being added too early, leading to
 Customizer live preview bugs in 6.4.

 The Customizer live preview broke because of [56635], however the root
 cause for the bug was a lower-level problem that had been present since
 WordPress 5.8: The block theme specific functions
 `_add_default_theme_supports()` and `wp_enable_block_templates()` were
 being hooked into the `setup_theme` action, which fires too early to
 initialize theme features. Because of that, theme functionality would be
 initialized before the current theme setup being completed. In the case of
 the Customizer, that includes overriding which theme is the current theme
 entirely, thus leading to an inconsistent experience.

 This changeset fixes the bug by moving those two callbacks to the
 `after_setup_theme` action, which is the appropriate action to initialize
 theme features.

 Props karl94, hellofromTonya, joemcgill, flixos90.
 Merges [57009] to the 6.4 branch.
 Fixes #59732.
 See #18298, #53397, #54597.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59732#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform