[wp-trac] [WordPress Trac] #59732: Theme live preview is broken

[WordPress Trac]

#59732: Theme live preview is broken
-------------------------------------------------+-------------------------
 Reporter:  karl94                               |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  Themes                               |     Version:  5.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch => has-patch needs-testing has-testing-info


Comment:

 Patch: https://github.com/WordPress/wordpress-develop/pull/5574

 The patch changes the "when" (to after the theme is set up) for:
 * adding block theme's theme supports (including `'block-templates'`),
 * turning on `'should_load_separate_core_block_assets'`,
 * and removing Customizer's Menu panel.

 Testing instructions need to test for:
 * the bug reported (i.e. Customizer themes live preview)
 * and the above changes for block themes, i.e. to ensure the patch does
 not change the behavior.

 == Test Instructions: Customizer themes live preview bug

 === Steps to Reproduce
 Though listed in the ticket's description, repeating here to keep all
 testing instructions in one place:

 1. Load WordPress 6.4 RC2
 2. Install some classic themes e.g. twentytwenty and twentynineteen
 3. Activate twentynineteen
 4. Live preview twentytwenty 🐞 Bug occurs.

 === Expected Results

 When reproducing a bug:
 - ❌ Before applying the patch, the live preview should not work.

 When testing a patch to validate it works as expected:
 - ✅ After applying the patch, the live preview should work.

 == Test Instructions: Block themes not affected by the patch

 Though listed in the ticket's description, repeating here to keep all
 testing instructions in one place:

 1. Load WordPress 6.4 RC2.
 2. With a classic theme, such as Twenty Twenty-One (TT1) activated, open
 Customizer in a different browser tab or ease of access in the next steps.
    * Notice: The "Menus" item in the navigation sidebar.
 3. Activate Twenty Twenty-Four (TT4).
 4. Refresh Customizer. Expected: The "Menus" item should not be in the
 navigation sidebar. ✅
 5. Apply the patch.
 6. Repeat step 4. Expected: No "Menus" item ✅
 7. Navigate to Posts > and open a post.
    * Expected: "Featured image" subpanel should render in the right
 sidebar and be functional. ✅

 === Expected Results

 After applying the patch, the following should still work for block
 themes:
 * ✅ In Customizer, the "Menus" item should not in the navigation sidebar.
 * ✅ When adding or editing a post, the "Featured image" subpanel should
 render and be functional.

   **Test Report Icons:**
   🐞 <= Indicates where issue ("bug") occurs.
   ✅ <= Behavior is ''expected''.
   ❌ <= Behavior is ''NOT expected''.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59732#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform