[wp-trac] [WordPress Trac] #56172: Strict comparisons not used.

WordPress Trac noreply at wordpress.org
Thu Oct 26 00:02:19 UTC 2023


#56172: Strict comparisons not used.
--------------------------------------+-------------------------------
 Reporter:  hilayt24                  |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  General                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |     Focuses:  coding-standards
--------------------------------------+-------------------------------

Comment (by sabernhardt):

 Those two comparisons in `wp-admin/options-general.php` both involve
 output of `get_option()`:
 - `( 0 == $current_offset )` -
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/options-
 general.php?rev=56680#L245 line 245]
 - `( get_option( 'start_of_week' ) == $day_index )` -
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/options-
 general.php?rev=56680#L445 line 445]

 The six comparisons in `wp-admin/network/sites.php` were updated in
 [55672] and [55876].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56172#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list