[wp-trac] [WordPress Trac] #59718: Short-term (WP 6.4) hotfix to prevent fatal error in standalone Gutenberg (<16.5)
WordPress Trac
noreply at wordpress.org
Wed Oct 25 14:49:39 UTC 2023
#59718: Short-term (WP 6.4) hotfix to prevent fatal error in standalone Gutenberg
(<16.5)
-----------------------------------------------+---------------------
Reporter: rebasaurus | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.4
Component: Upgrade/Install | Version:
Severity: critical | Resolution:
Keywords: reporter-feedback close has-patch | Focuses:
-----------------------------------------------+---------------------
Comment (by hellofromTonya):
Heads up:
The class `WP_REST_Global_Styles_Controller_Gutenberg` (in `lib/class-wp-
rest-global-styles-controller-gutenberg.php`) is overloading and invoking
the `validate_custom_css()` method
* Gutenberg 16.5.0:
[https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.5.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L732 overloading]
and [https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.5.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L329 invoking]
* Gutenberg 16.5.1:
[https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.5.1/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L732 overloading]
and [https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.5.1/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L329 invoking]
* Gutenberg 16.6.0:
[https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.6.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L732 overloading]
and [https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.6.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L329 invoking]
* Gutenberg 16.7.0:
[https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.7.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L709 overloading]
and [https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.7.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L328 invoking]
* Gutenberg 16.7.1:
[https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.7.1/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L709 overloading]
and [https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.7.1/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L328 invoking]
* Gutenberg 16.8.0:
[https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.8.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L709 overloading]
and [https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.8.0/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L328 invoking]
* Gutenberg 16.8.1:
[https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.8.1/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L709 overloading]
and [https://plugins.trac.wordpress.org/browser/gutenberg/tags/16.8.1/lib
/class-wp-rest-global-styles-controller-gutenberg.php#L328 invoking]
* Gutenberg `trunk`:
[https://github.com/WordPress/gutenberg/blob/trunk/lib/class-wp-rest-
global-styles-controller-gutenberg.php#L709 overloading] and
[https://github.com/WordPress/gutenberg/blob/trunk/lib/class-wp-rest-
global-styles-controller-gutenberg.php#L328 invoking]
Reverting [56575] will impact not only those past releases, but also
current and future development. Why? Reverting the method back to
`private` means the method cannot be overloaded or invoked within
Gutenberg.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59718#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list