[wp-trac] [WordPress Trac] #59723: Pattern file containing PHP constant from theme causes fatal error on update to WordPress 6.4

[WordPress Trac]

#59723: Pattern file containing PHP constant from theme causes fatal error on
update to WordPress 6.4
-------------------------------------------------+-------------------------
 Reporter:  fabiankaegy                          |       Owner:  joemcgill
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  high                                 |   Milestone:  6.4
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch changes-requested needs-   |     Focuses:
  testing has-testing-info                       |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch => has-patch changes-requested needs-testing has-
     testing-info


Comment:

 Updating the keywords:

 Patch: https://github.com/WordPress/wordpress-develop/pull/5568

 * `needs-testing` is testing the patch, once it's ready.
 * `has-testing-info`: found in comment:10
 * `changes-requested`: discussion is happening in the patch of possible
 changes.

 Alerted contributors in the
 [https://wordpress.slack.com/archives/C02RQBWTW/p1698240173861709
 Make/Core core channel] with a call for testing and review.

 Cross-sharing here:
 >👉 **Should it go into 6.4 RC3?**
 >IMO yes, fatals should be fixed. But there must be ''high confidence''
 that the patch does indeed resolve the fatal without side effects.

 "high confidence" comes from code reviews and test reports. The more test
 reports, the higher the confidence.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59723#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform