[wp-trac] [WordPress Trac] #59694: Regression: Fix duotone support to be compatible with enhanced pagination
WordPress Trac
noreply at wordpress.org
Tue Oct 24 10:57:19 UTC 2023
#59694: Regression: Fix duotone support to be compatible with enhanced pagination
-------------------------------------------------+-------------------------
Reporter: cbravobernal | Owner:
| hellofromTonya
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 6.4
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests gutenberg- | Focuses:
merge dev-reviewed |
-------------------------------------------------+-------------------------
Comment (by hellofromTonya):
In [changeset:"56996" 56996]:
{{{
#!CommitTicketReference repository="" revision="56996"
Tests: Fix static property handling in r56991.
Fixes static property handling for `WP_Duotone::$block_css_declarations`
in the
`Tests_Block_Supports_Duotone::test_css_declarations_are_generated_even_with_empty_block_content()`:
* Fixes `ReflectionProperty::setValue()` to use an instance of
`WP_Duotone`.
* Adds an inline comment to explain why a static class (i.e. a class that
is not intended to be an object by design as it only contains static
properties and methods) needs an instance, i.e. needed for PHP 8.3 and
higher.
* Resets the static property's value to its original value, i.e. before
the test started.
Follow-up to [56991].
Props costdev.
See #59694.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59694#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list