[wp-trac] [WordPress Trac] #59704: Twenty Fifteen: harden twentyfifteen_fonts_url code for php 8.1 (was: TwentyFifteen: refactor twentyfifteen_fonts_url code for php 8.1)

[WordPress Trac]

#59704: Twenty Fifteen: harden twentyfifteen_fonts_url code for php 8.1
---------------------------+------------------------------
 Reporter:  jordesign      |       Owner:  (none)
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------------------
Changes (by sabernhardt):

 * type:  defect (bug) => enhancement


Old description:

> If twentyfifteen_fonts_url is overwritten and no fonts are returned then
> line 184 of functions.php creates a warning as the subject of str_replace
> does not exist.

New description:

 If `twentyfifteen_fonts_url` is overwritten and no fonts are returned then
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyfifteen/functions.php?rev=56556#L184 line 184] of
 `functions.php` creates a warning as the subject of `str_replace` does not
 exist.

--

Comment:

 I'm changing this to an enhancement because it should work with the
 documented type.

 However, it could be worth fixing type errors, as I had made that error
 with Twenty Fifteen and/or Twenty Sixteen before working on the patches in
 #55985.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59704#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform