[wp-trac] [WordPress Trac] #59694: Backport Gutenberg #55415 - Make duotone support compatible with enhanced pagination

[WordPress Trac]

#59694: Backport Gutenberg #55415 - Make duotone support compatible with enhanced
pagination
--------------------------+------------------------------
 Reporter:  cbravobernal  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Description changed by cbravobernal:

Old description:

> Backport of #55415
>
> This fix makes the duotone compatible with the enhanced pagination by
> making sure that the CSS is always on the page, even when the posts have
> no featured image. It also prevents the duotone from interfering with
> other blocks using wp_unique_id.
>
> With the current implementation of enhanced pagination, we are still not
> detecting the CSS corresponding to each block. Therefore, for the
> enhanced pagination to work correctly, the CSS of the blocks present in
> the Post Template must be stable on all pages.
>
> The featured image block can contain a duotone, but the duotone CSS is
> only inlined when the block is not empty. As posts can have or not have a
> featured image, if all posts on one page do not have a featured image,
> the duotone CSS will not load, and when you paginate, the CSS will not be
> applied to the posts that do have a featured image.
>
> In addition, some duotone settings use the wp_unique_id, and as it is a
> conditional use, this can break the stability of the rest of the blocks
> that use wp_unique_id causing another series of problems like those
> described in #55230.

New description:

 Backport of https://github.com/WordPress/gutenberg/pull/55415

 This fix makes the duotone compatible with the enhanced pagination by
 making sure that the CSS is always on the page, even when the posts have
 no featured image. It also prevents the duotone from interfering with
 other blocks using wp_unique_id.

 With the current implementation of enhanced pagination, we are still not
 detecting the CSS corresponding to each block. Therefore, for the enhanced
 pagination to work correctly, the CSS of the blocks present in the Post
 Template must be stable on all pages.

 The featured image block can contain a duotone, but the duotone CSS is
 only inlined when the block is not empty. As posts can have or not have a
 featured image, if all posts on one page do not have a featured image, the
 duotone CSS will not load, and when you paginate, the CSS will not be
 applied to the posts that do have a featured image.

 In addition, some duotone settings use the wp_unique_id, and as it is a
 conditional use, this can break the stability of the rest of the blocks
 that use wp_unique_id causing another series of problems like those
 described in https://github.com/WordPress/gutenberg/issues/55230)

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59694#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform