[wp-trac] [WordPress Trac] #58898: Fix WP_Text_Diff_Renderer_Table magic methods for PHP 8.2 dynamic properties

[WordPress Trac]

#58898: Fix WP_Text_Diff_Renderer_Table magic methods for PHP 8.2 dynamic
properties
-------------------------------------------------+-------------------------
 Reporter:  antonvlasenko                        |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  Administration                       |     Version:  4.0
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  php82 has-patch has-unit-tests       |     Focuses:  php-
  commit                                         |  compatibility
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 In [changeset:"56938" 56938]:
 {{{
 #!CommitTicketReference repository="" revision="56938"
 Code Modernization: Declare dynamic properties on
 WP_Text_Diff_Renderer_Table.

 Core uses 3 known, named, dynamic properties on the
 `WP_Text_Diff_Renderer_Table` class:

 * `_title`
 * `_title_left`
 * `_title_right`

 When reviewing revisions (within the admin UI), `wp_text_diff()` passes
 the arguments (without the leading `_`) to a new instance, which raised
 deprecation notices (see [56354]).

 Note: the parent class adds the leading `_` to each of these properties
 (see [7747]).

 The deprecation notices are resolved by declaring each of these known,
 named, dynamic properties on the class, per the #56034 mitigation
 strategy. These new properties are not initialized to retain their
 previous `null` behavior.

 Follow-up to [56354], [23506], [7747].

 Props wildworks, antonvlasenko, hellofromTonya, ironprogrammer, kafleg,
 mukesh27, nicolefurlan, presskopp, sabernhardt.
 Fixes #59431.
 See #58898, #56034.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58898#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform