[wp-trac] [WordPress Trac] #59607: HTML API: Fix - avoid calling subclass method while internally scanning in Tag Processor
WordPress Trac
noreply at wordpress.org
Fri Oct 13 19:16:37 UTC 2023
#59607: HTML API: Fix - avoid calling subclass method while internally scanning in
Tag Processor
-------------------------------------------------+-------------------------
Reporter: dmsnell | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.4
Component: HTML API | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests needs- | Focuses:
testing-info |
-------------------------------------------------+-------------------------
Comment (by dmsnell):
Thanks @nicolefurlan - for testing, it would be helpful for someone to
follow the pattern in the added unit test. There should be no existing
code affected by this change, so I think any testing is going to follow
one of three approaches:
- replicate the unit test
- smoke test WordPress with this patch and ensure that things aren't
entirely obviously broken (e.g. do heading block H2's have the `wp-block-
heading` class). most of these smoke-tests are already covered by existing
tests in the test suite.
- think up some interesting way to try and break the HTML processing,
which is what led to this patch in the first place.
I'm sorry I don't have better testing instructions, but on the other hand,
at least the test suite is fairly comprehensive, so I'm confident this
isn't causing blatant and unwanted side-effects
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59607#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list