[wp-trac] [WordPress Trac] #59390: Incorrect method / function args used in bin/tests/core/tests/rest-api/wpRestMenuItemsController.php

[WordPress Trac]

#59390: Incorrect method / function args used in bin/tests/core/tests/rest-
api/wpRestMenuItemsController.php
-----------------------------------------+-----------------------
 Reporter:  david.binda                  |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  6.4
Component:  Menus                        |     Version:  5.9
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch changes-requested  |     Focuses:  rest-api
-----------------------------------------+-----------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch => has-patch changes-requested


Comment:

 Thanks for the patch!

 I'm a bit confused here. The
 `Tests_REST_WpRestMenuItemsController::check_menu_item_data()` method
 requires four arguments, so unless I'm missing something, passing only
 three would cause a fatal error, and the test only passes accidentally
 because that branch is never hit.

 This could use some more investigation.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59390#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform